feat(puppeteer): Upgrade to axe-core 4.3 #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
commented
Aug 12, 2021
Comment on lines
8
to
10
| * In this project, most async calls needs to block execution, such as | ||
| * the driver.switchTo().frame() calls. These must run in the correct order | ||
| * to avoid stale element references and infinite loops testing the same frame. |
There was a problem hiding this comment.
Oops, copy from WDJS. Will fix.
straker
approved these changes
Aug 13, 2021
| await new AxePuppeteer(page, axeSource).analyze(); | ||
| assert(evalSpy.calledWith(axeSource)); | ||
| }); | ||
| // TODO: Defaults to using the bundled axe-core source |
There was a problem hiding this comment.
Do we need to worry about this TODO in this pr?
There was a problem hiding this comment.
Was copied from the other source... probably shouldn't be here. I'll just take it out.
Comment on lines
470
to
472
| // HACK: work around axe-core (incorrectly) requiring this to be | ||
| // a function (see https://github.com/dequelabs/axe-core/issues/974). | ||
| (config.checks as any)[0].evaluate = 'function () { return false }'; |
There was a problem hiding this comment.
I believe this should no longer be required as evaluate can be a string in the typings
Suggested change
| // HACK: work around axe-core (incorrectly) requiring this to be | |
| // a function (see https://github.com/dequelabs/axe-core/issues/974). | |
| (config.checks as any)[0].evaluate = 'function () { return false }'; | |
| config.checks[0].evaluate = 'function () { return false }'; |
There was a problem hiding this comment.
Copied this from the previous implementation, but yeah it can be removed.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.